Skip to content

tests: cover non-ASCII filename encoding in Content-Disposition #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taoeffect merged 2 commits into from
Aug 25, 2026
Merged

tests: cover non-ASCII filename encoding in Content-Disposition #331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d17eea9
tests: cover non-ASCII filename encoding in Content-Disposition
pedrogaudencio Aug 24, 2026
8595ef2
Merge branch 'master' into filename-non-ascii-whitespace-test
pedrogaudencio Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/httplib/serve_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,12 @@ func TestServeSetHeadersContentDisposition(t *testing.T) {
ServeSetHeaders(w, &ServeHeaderOptions{Filename: "foo.zip", Disposition: "inline"})
assert.Equal(t, `inline; filename="foo.zip"; filename*=UTF-8''foo.zip`, w.Header().Get("Content-Disposition"))

// the "filename*" parameter is percent-encoded, while the legacy "filename" parameter
// keeps the raw UTF-8 bytes (only backslashes and quotes are escaped)
w = httptest.NewRecorder()
ServeSetHeaders(w, &ServeHeaderOptions{Filename: "café résumé.pdf"})
assert.Equal(t, `attachment; filename="café résumé.pdf"; filename*=UTF-8''caf%C3%A9%20r%C3%A9sum%C3%A9.pdf`, w.Header().Get("Content-Disposition"))

// quotes and backslashes must be escaped in the quoted-string form and
// percent-encoded in the RFC 5987 parameter, so the filename cannot break
// out of the quoted-string and inject disposition parameters
Expand Down
Loading