Skip to content

ci: drop duplicate operand in actions job condition - #329

Merged
taoeffect merged 1 commit into
masterfrom
refactor-pull-compliance-workflow
Aug 24, 2026
Merged

ci: drop duplicate operand in actions job condition#329
taoeffect merged 1 commit into
masterfrom
refactor-pull-compliance-workflow

Conversation

@pedrogaudencio

Copy link
Copy Markdown
Collaborator

Closes #304

AI Disclosure

Co-authored with: Opus 5

@pedrogaudencio pedrogaudencio self-assigned this Aug 23, 2026
Copilot AI lite review requested due to automatic review settings August 23, 2026 10:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pedrogaudencio

pedrogaudencio commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator Author

/review


AI review started.

@github-actions

Copy link
Copy Markdown

Advanced AI Review

  • Type: Agentic (crush)
  • Model: glm-5.3
Click to expand review

No problems found.

Verification performed:

  • .github/workflows/pull-compliance.yml:197X || X is logically identical to X, so collapsing the duplicated operand is a pure no-op; job triggering behavior is unchanged.
  • The actions output it references is properly plumbed through in .github/workflows/files-changed.yml:12-13 (workflow-level) and :33 (job-level), and its filter (.github/workflows/files-changed.yml:77-79) covers both inputs of the job's make lint-actions step (Makefile:414 runs actionlint over the workflow files plus the Makefile-defined ACTIONLINT_PACKAGE variable).
  • Grepped all other workflow files for the same duplicated-operand pattern (pull-db-tests.yml, pull-docker-dryrun.yml, pull-tests.yml, pull-e2e-tests.yml) — no other occurrence exists in this repo, so the issue's follow-up concern is already resolved.

The change is minimal, correct, and safe to merge as-is.


Review generated using glm-5.3 via Z.AI. Comment /review to re-run.

@pedrogaudencio

Copy link
Copy Markdown
Collaborator Author

@taoeffect approved! ✅

@taoeffect
taoeffect merged commit 1c44b16 into master Aug 24, 2026
33 checks passed
@taoeffect
taoeffect deleted the refactor-pull-compliance-workflow branch August 24, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: remove condition in the actions job of pull-compliance.yml

3 participants