This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @tomasAlabes, 2nd Buildtox
$PRE_COMMIT_CMD
5th Buildtox
$PRE_COMMIT_CMD
7th Buildtox
$PRE_COMMIT_CMD
9th Buildtox
$PRE_COMMIT_CMD
TravisBuddy Request Identifier: 9b5a9640-7ced-11ea-88f3-21f06a246c38 |
Thanks for the pr! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
base_path
option doesn't do what is expected, all writes should be done in the passedbase_path
.Which issue(s) this PR fixes:
Fixes #833, #1035, #1289
This lets this bot be used in systems where the writes to the FS are limited, and you need all writes go in 1 place.
Special notes for your reviewer:
I'm new to Python so I wasn't able to test this or try it in my project to make sure it 100% works and/or all cases are covered (I did run all
pre-commit
andtox
commands). If the maintainer wants to discard this to give a similar/better solution, it's fine with me.Does this PR introduce a user-facing change?:
Additional documentation e.g. usage docs, etc.: