-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add FlatList implementation #77
base: master
Are you sure you want to change the base?
Conversation
@jsteiner Hi Josh, I saw that you implemented ListView and talked about using FlatList in your commit message. Can you please take a look at this and give us some feedback? |
@jsteiner, do you have any comments for this? |
Sorry for the hold up. Got lost in my inbox. I think this is a good first pass. |
Thank you for the feedback, I'll clean it up and get rid of the WIP tag as well. React 0.43 has been released, will make sure nothing else breaks with that. |
@jaischeema Thanks for you work! Are the changes to the I think we should consider moving the examples in their own repository/repositories, especially since everyone who uses elm-native-ui will also download and self-publish all the examples to their elm-stuff. |
@ohanhi No, they are not intentional, I will revert those. I think its time to add the UIExplorer project to showcase different components and keep only one one |
This is still very much in works but I wanted to get some feedback if is the right approach. We are currently encoding/decoding the data on every render data, not sure how efficient that would be.
Next step would be to implement
shouldItemUpdate
method to make it more efficient.