contrib/aws: skip trn1 tests for PRs without relevant code changes#12091
Open
a-szegel wants to merge 1 commit intoofiwg:mainfrom
Open
contrib/aws: skip trn1 tests for PRs without relevant code changes#12091a-szegel wants to merge 1 commit intoofiwg:mainfrom
a-szegel wants to merge 1 commit intoofiwg:mainfrom
Conversation
a-szegel
force-pushed
the
only-run-trn-against-efa-related-changes
branch
3 times, most recently
from
ad29421 to
c80ab84
Compare
Contributor
Author
|
Build 4 in AWS CI show's that this is working with this temporary testing commit applied (removes contrib from list and trn1 doesn't build) |
a-szegel
force-pushed
the
only-run-trn-against-efa-related-changes
branch
from
c80ab84 to
3d4b128
Compare
When many PR builds are queued, limited lockable resources (especially trn1.32xlarge) cause builds to time out. Add a "Check for relevant changes" stage that skips all testing when the PR does not modify paths that could affect provider behavior: prov/efa, prov/shm, prov/util, prov/tcp, src, include, fabtests, contrib/aws, and build system files. PRs that only touch documentation, other providers, or unrelated configs will complete immediately after checkout, freeing up CI resources. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
a-szegel
force-pushed
the
only-run-trn-against-efa-related-changes
branch
from
3d4b128 to
e9df49e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trn1.32xlarge instances use a limited pool of lockable resources that causes builds to time out when too many PRs are queued. Gate the trn1 test stage on a new have_efa_provider_changes() helper that checks whether the PR modifies paths that could affect EFA provider behavior (prov/efa, prov/shm, prov/util, src, include, fabtests, contrib/aws, and build system files).
PRs that only touch documentation, other providers, or CI configs unrelated to AWS will skip the trn1 stage entirely, reducing lock contention.