prov/efa: Implement FI_CONTEXT2 in EFA Direct #10707
Open
+105
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-szegel
reviewed
Jan 17, 2025
This commit removes the x86-64 architecture check from the static_assert conditional compilation directive. The static_assert feature is not architecture-dependent and should be checked on all platforms that support it. Signed-off-by: Jessie Yang <[email protected]>
shijin-aws
requested changes
Jan 20, 2025
shijin-aws
previously approved these changes
Jan 21, 2025
shijin-aws
reviewed
Jan 21, 2025
shijin-aws
reviewed
Jan 21, 2025
| efa_unit_test_buff_construct(&send_buff, resource, 4096 /* buff_size */); | ||
|
|
||
| assert_int_equal(g_ibv_submitted_wr_id_cnt, 0); | ||
| ret = fi_send(resource->ep, send_buff.buff, send_buff.size, | ||
| fi_mr_desc(send_buff.mr), addr, (void *) 12345); | ||
| fi_mr_desc(send_buff.mr), addr, &ctx); | ||
| assert_int_equal(ret, 0); | ||
| assert_int_equal(g_ibv_submitted_wr_id_cnt, 1); | ||
|
|
There was a problem hiding this comment.
Not related to this PR, but generally it worth checking the completion flags in the cq entry to be correct.
Store the completion flags and peer address in FI_CONTEXT2 and retrieve later when writing cq. Signed-off-by: Jessie Yang <[email protected]>
sunkuamzn
approved these changes
Jan 22, 2025
shijin-aws
approved these changes
Jan 22, 2025
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the completion flags and peer address in FI_CONTEXT2 and retrieve later when writing cq.