Skip to content
This repository was archived by the owner on Feb 8, 2025. It is now read-only.

Upgrades :D [Laravel 11, Vite, Security] - #1498

Open
countnoobula wants to merge 8 commits into
officelifehq:mainfrom
ConsultSafe:refactor/upgrade-laravel
Open

Upgrades :D [Laravel 11, Vite, Security]#1498
countnoobula wants to merge 8 commits into
officelifehq:mainfrom
ConsultSafe:refactor/upgrade-laravel

Conversation

@countnoobula

@countnoobula countnoobula commented Jul 4, 2024

Copy link
Copy Markdown

WARNING: THIS IS BIG

CHROME USES 1.2GB AND FREEZES IN FILES CHANGED TAB.

I RECOMMEND REVIEWING THE CHANGES LOCALLY <3

I must cleanup our commit structure. We have a fork of this that we're cleaning up that I've copied into here, but some of the commits are sensitive.

This is a general dump and I'll rebase the commits [We all love commitizen].

Due to the changes to the action files, I don't know how well Github is going to run the new versions. It may all break.


Core changes:

  • Upgrade to Laravel 11
  • Migrate from Webpack to Vite
  • Resolve security dependencies (3 outstanding)

Bug fixes:

  • On the software page, the converted currency did not have a decimal
  • Email verification got broken due to package upgrade and is now fixed
  • The Duration component got broken due to package upgrade and is now fixed

Other changes:

  • We generally use Laravel Pint, so took that as preference
  • We upgraded to use PHP 8.3, although 8.2 compatibility should work

@countnoobula
countnoobula requested a review from a team as a code owner July 4, 2024 20:48
@countnoobula
countnoobula requested review from asbiin and removed request for a team July 4, 2024 20:48
@CLAassistant

CLAassistant commented Jul 4, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

$hoursLeft = $now->diffInHours($date);

if ($hoursLeft < 0) {
$hoursLeft = $hoursLeft * -1;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit of an odd bug

@djaiss
djaiss requested review from djaiss and removed request for asbiin July 4, 2024 20:59
@@ -46,7 +46,7 @@
<div>

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is messy, I'll break it apart for us.

there was an issue somewhere here, trying to find it in our history
@djaiss

djaiss commented Jul 4, 2024

Copy link
Copy Markdown
Member

Such a huge PR.
Thanks so much for all your hard work.

Why did you remove the phpstan package? We need it. Could you add it back?
Oh, and apparently https://github.com/vimeo/psalm is missing too.
This generates errors in the CI since we can't check if there are issues in the code.

@countnoobula

Copy link
Copy Markdown
Author

Only a pleasure! We love your products!

I can definitely add those back in! I'll need to recreate the baselines due to pint's changes.
We rely quite heavily on Qodana. They do have opensource licenses available, so it could be good to apply for it! I'd be more than happy to help configure to your requirements.

Can I add an action to lint the commits to commitizen standard?

@countnoobula

Copy link
Copy Markdown
Author

Things have been a bit busy, I will attend to it this week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants