18.0 estate ibmo #818
18.0 estate ibmo #818
Conversation
|
|
estate/__manifest__.py
Outdated
| 'application': True, | ||
| 'auto_install': False, | ||
| 'license': 'LGPL-3', | ||
| } |
There was a problem hiding this comment.
We try to put a return character at the end of the last line in every file.
This way, when a new line is added to the file, that line is not impacted.
estate/models/estate_property.py
Outdated
| garage = fields.Boolean(string='Garage') | ||
| garden = fields.Boolean(string='Garden') | ||
| garden_area = fields.Integer(string='Garden Area') | ||
| arden_orientation = fields.Selection(string='Arden Orientation', selection=[ |
There was a problem hiding this comment.
arden_orientation => garden_orientation 😉
estate/models/estate_property.py
Outdated
| ('north', 'North'), | ||
| ('south', 'South'), | ||
| ('east', 'East'), | ||
| ('west', 'West') |
There was a problem hiding this comment.
In python, we try to follow the following convention for quoting strings:
- single quote for technical terms
- double quotes for displayed texts
=> ('north', "North")
estate/views/estate_menus.xml
Outdated
|
|
||
| <menuitem id="estate_property_menu_root" name="Estate Property Menu"> | ||
| <menuitem id="estate_property_level_menu" name="First Level"> | ||
| <menuitem id="estate_property_menu_action" action="estate_property_menu_action"/> |
There was a problem hiding this comment.
This menuitem has the same id as the action. Do not mention menu in the action id, this will solve the data import issue you are encountering.
estate/models/estate_property.py
Outdated
| arden_orientation = fields.Selection(string='Arden Orientation', selection=[ | ||
| ('north', 'North'), | ||
| ('south', 'South'), | ||
| ('east', 'East'), | ||
| ('west', 'West') | ||
| ]) No newline at end of file | ||
| garden_orientation = fields.Selection(string='Arden Orientation', selection=[ | ||
| ('north', "North"), | ||
| ('south', "South"), | ||
| ('east', "East"), | ||
| ('west', "West") | ||
| ]) |
There was a problem hiding this comment.
string='Arden => string="Garden 😉
But, let's try to make those changes in the commit where they originally appeared.
Look at the git rebase -i command to rewrite you branch's history.
You will then need to use git push --force-with-lease to send such changes to the repo. (Try not to use git push --force to avoid accidents when working together with other people on a common branch)
Upon merge, you will want the commits of your PR to actually describe what is changed and why. The intermediary development attempts and typo fixes are not interresting for the future reader who will try to find out why some lines were added three years ago. So, for small intra-branch fixes, always try to make them in the commit where they should initially have been correct.
No description provided.