18.0 training mdoy #817
18.0 training mdoy #817
Conversation
|
|
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models | |||
There was a problem hiding this comment.
We try to include the return character on the last line in every file.
This way when adding more lines later, the previously last line is not impacted in the diff.
estate/models/estate_property.py
Outdated
| garden_orientation = fields.Selection( | ||
| string='Type', | ||
| selection=[('north', 'North') ,('south', 'South'), ('east', 'East'), ('west', 'West')], |
There was a problem hiding this comment.
In python, we try to follow the following convention for quoting strings:
- single quote for technical terms
- double quotes for displayed texts
=> ('north', "North")
Let's try to apply it during this exercise, even though the existing codebase contains many counter examples.
| @@ -2,8 +2,8 @@ | |||
|
|
|||
There was a problem hiding this comment.
Commit messages are supposed to be truncated at 72 columns, so, this one is bit too long.
But after a blank line you can put as much text as you want.
Anyway, do not worry about that, instead let's take this opportunity for some git training.
Try to make these fixes directly within the commits where the lines were introduces.
Look at the git rebase -i command to rewrite the history on your branch, and then you'll need to git push --force-with-lease to send such a change to the repo. (Try not to use git push --force to avoid accidents when you will be working with other people on a common branch)
estate/models/__init__.py
Outdated
| @@ -1 +1 @@ | |||
| from . import estate_property | |||
| from . import estate_property, estate_property_type, estate_property_tag, estate_property_offer | |||
There was a problem hiding this comment.
We try to have imports in __init__.py files separated on distinct lines.
Always the same reason, to reduce the diff when making future changes.
martiyen
force-pushed
the
18.0-training-mdoy
branch
from
fd226d5 to
91b868c
Compare
No description provided.