Skip to content

[ADD] estate: New module to manage estates #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: 18.0
Choose a base branch
from

Conversation

baje-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Jun 17, 2025

Pull request status dashboard

Copy link

@bso-odoo bso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few cosmetic comments.

@baje-odoo baje-odoo force-pushed the 18.0-fix-invoices-baje branch 2 times, most recently from 5f9528b to 8bf2ec2 Compare June 18, 2025 09:01
@bso-odoo
Copy link

Actually, the [ADD] prefix in commit titles is only when adding a new module, we use the prefix [IMP] for improvement when adding stuff inside a module, and [FIX] when making a fix on an existing feature.

@baje-odoo baje-odoo changed the title Chapter 2 [ADD] estate: New module to manage estates Jun 18, 2025
@baje-odoo baje-odoo force-pushed the 18.0-fix-invoices-baje branch 3 times, most recently from b008594 to 36574bb Compare June 19, 2025 08:20
Copy link

@bso-odoo bso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few comments:

Comment on lines 6 to 12
<<<<<<< HEAD
'security/ir.model.access.csv',
'views/estate_property_views.xml',
'views/estate_menus.xml',
=======
'security/ir.model.access.csv'
>>>>>>> 6f53f08 (Security)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is an unresolved git conflict here.

Comment on lines 16 to 28
living_area = fields.Integer("Living Area")
living_area = fields.Integer("Living Area (sqm)")
facades = fields.Integer("Facades")
garage = fields.Boolean("Garage")
garden = fields.Boolean("Garden")
garden_area = fields.Integer("Garden Area")
garden_area = fields.Integer("Garden Area (sqm)")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these changes can be done in the commit where those lines were initially added.

Comment on lines 5 to 20
<<<<<<< HEAD
'data': [
'security/ir.model.access.csv',
'views/estate_property_views.xml',
'views/estate_menus.xml',
=======
'security/ir.model.access.csv'
>>>>>>> 6f53f08 (Security)
],
'author': "baje",
'category': 'Uncategorized',
'description': """
An app to manage a Real Estate Agency
""",
'application': True,
} No newline at end of file
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, it is fixed here. Let's try to make such fixes in their original commit - so that it looks like the problem just never happened.

<h1>
<field name="name"/>
</h1>
<field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is no tag_ids field (yet) at this point.

Comment on lines 1 to 3
access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file
access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1
access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to introduce a return on the last line on the first version of each file in order to avoid such diffs. (This change should typically only be about adding one new line)

name = fields.Char("Name", required=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning is still there... I guess your last line is not empty... maybe it contains a few spaces. (This happens in many files)

@baje-odoo baje-odoo force-pushed the 18.0-fix-invoices-baje branch from a905a17 to 716c663 Compare June 19, 2025 13:36
@baje-odoo baje-odoo force-pushed the 18.0-fix-invoices-baje branch from 41b9431 to 2a00cff Compare June 20, 2025 07:06
@baje-odoo baje-odoo force-pushed the 18.0-fix-invoices-baje branch from 2769e30 to 6871bc9 Compare June 20, 2025 08:09
@baje-odoo baje-odoo force-pushed the 18.0-fix-invoices-baje branch from 5259f06 to 9a0df1a Compare June 20, 2025 08:27
@baje-odoo baje-odoo force-pushed the 18.0-fix-invoices-baje branch 4 times, most recently from 11b3175 to 759af29 Compare June 20, 2025 11:30
@baje-odoo baje-odoo force-pushed the 18.0-fix-invoices-baje branch from 759af29 to d5a3567 Compare June 20, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants