-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[ADD] estate: New module to manage estates #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few cosmetic comments.
5f9528b
to
8bf2ec2
Compare
Actually, the |
b008594
to
36574bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few comments:
estate/__manifest__.py
Outdated
<<<<<<< HEAD | ||
'security/ir.model.access.csv', | ||
'views/estate_property_views.xml', | ||
'views/estate_menus.xml', | ||
======= | ||
'security/ir.model.access.csv' | ||
>>>>>>> 6f53f08 (Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there is an unresolved git conflict here.
estate/models/estate_property.py
Outdated
living_area = fields.Integer("Living Area") | ||
living_area = fields.Integer("Living Area (sqm)") | ||
facades = fields.Integer("Facades") | ||
garage = fields.Boolean("Garage") | ||
garden = fields.Boolean("Garden") | ||
garden_area = fields.Integer("Garden Area") | ||
garden_area = fields.Integer("Garden Area (sqm)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these changes can be done in the commit where those lines were initially added.
estate/__manifest__.py
Outdated
<<<<<<< HEAD | ||
'data': [ | ||
'security/ir.model.access.csv', | ||
'views/estate_property_views.xml', | ||
'views/estate_menus.xml', | ||
======= | ||
'security/ir.model.access.csv' | ||
>>>>>>> 6f53f08 (Security) | ||
], | ||
'author': "baje", | ||
'category': 'Uncategorized', | ||
'description': """ | ||
An app to manage a Real Estate Agency | ||
""", | ||
'application': True, | ||
} No newline at end of file | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, it is fixed here. Let's try to make such fixes in their original commit - so that it looks like the problem just never happened.
<h1> | ||
<field name="name"/> | ||
</h1> | ||
<field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The is no tag_ids
field (yet) at this point.
estate/security/ir.model.access.csv
Outdated
access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | ||
access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 | ||
access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to introduce a return on the last line on the first version of each file in order to avoid such diffs. (This change should typically only be about adding one new line)
name = fields.Char("Name", required=True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning is still there... I guess your last line is not empty... maybe it contains a few spaces. (This happens in many files)
a905a17
to
716c663
Compare
41b9431
to
2a00cff
Compare
2769e30
to
6871bc9
Compare
5259f06
to
9a0df1a
Compare
11b3175
to
759af29
Compare
759af29
to
d5a3567
Compare
No description provided.