[IMP] ecommerce: delivery methods

[Donapi]

taskid-4016678

[robodoo]

[auva-odoo]

Hi @Donapi I added some comments and suggestions. In addition:

• I would also change shipping into delivery in the file checkout_payment_shipping.rst
• For the anchor names: I would keep shipping instead of delivery since the name of the file is still shipping.rst (cf our guidelines

[auva-odoo]

Suggested change

	delivery Methods`, click :guilabel:`New` and fill in the :ref:`fields
	Delivery Methods`, click :guilabel:`New` and fill in the :ref:`fields

[auva-odoo]

I would remove this section and:

• add the fields in the Inventory documentation where all other fields are documented (I know the rest of the documentation is not up-to-date either but I suggest we just add the fields)
• add a list item in the tip after line 91 to say that you can restrict the delivery method's availability using the fields in the Availability tab. (+ ref to Inventory doc); see my comment on line 85 about this as well.

[auva-odoo]

Should we rename this to align with the option's name and the more commonly used way of referring to it? I know the default delivery method's name is still Pick up in store but maybe we could use something more accurate as a heading (or stick with the existing heading).

Suggested change

	Pick up in store
	================
	Click & Collect
	===============

[auva-odoo]

Suggested change

	To allow customers to reserve products online and pay for/collect them in-store, go to
	:menuselection:`Website --> Configuration --> Settings`. Scroll to the :guilabel:`Delivery` section,
	enable :guilabel:`Click & Collect`, and :guilabel:`Save`.
	To allow customers to reserve products online and pay for/collect them in person at the store, go to
	:menuselection:`Website --> Configuration --> Settings`, scroll to the :guilabel:`Delivery` section,
	enable :guilabel:`Click & Collect`, and :guilabel:`Save`.

I don't think the rest of the sentence needs to be changed (granted this sentence comes from your other, very recent PR and this would affect translations as well).

[auva-odoo]

Suggested change

	Next, click :icon:`fa-arrow-right` :guilabel:`Configure Pickup Locations` to
	:ref:`set up <inventory/shipping_receiving/configure-delivery-method>` your delivery method.
	Then, click :icon:`fa-arrow-right` :guilabel:`Configure Pickup Locations` to
	:ref:`configure <inventory/shipping_receiving/configure-delivery-method>` the delivery method.

• The term set up typically refers to creating/establishing/installing something and configure doesn't
• avoid you/your when it's not really necessary

[auva-odoo]

Suggested change

	Ensure the :guilabel:`Provider` field is set to :guilabel:`Pickup in store`. Under the
	:guilabel:`Stores` tab, click :guilabel:`Add a line` to add the :guilabel:`Warehouse` and its
	:guilabel:`Address` where customers can collect their orders, and the :guilabel:`Opening hours`.
	Ensure the :guilabel:`Provider` field is set to :guilabel:`Pickup in store`. In the
	:guilabel:`Stores` tab, click :guilabel:`Add a line` and select the :ref:`warehouse(s) <`where where customers can collect their orders.

• You have to select the warehouse in the popup that opens
• Both the address and opening hours are set on the warehouse form, they are not added here (I think they can be edited from here but still I think it's best if we just send users to the relevant doc)

[auva-odoo]

Suggested change

	To allow customers to reserve products online and pay for/collect them in-store, go to
	To allow customers to reserve products online and pay for/collect them in-store, follow these steps:
	#. Go to

Since there are quite a few steps involved, I would use a numbered list here (and remove all sequencers like "then", "once you have xxx", etc.)

[auva-odoo]

Suggested change

	- **Services** are not available for the pick up in store option.
	- The Click & Collect option is not available for services.

[auva-odoo]

Suggested change

	Once your set up is complete, click the :guilabel:`Unpublish` button to change the status to
	:guilabel:`Publish`, making the delivery method available to customers. When the product is in
	stock, a **location selector** is displayed on :doc:`product <../products>` and
	:doc:`checkout <checkout>` pages.
	#. Click the :guilabel:`Unpublish` button to change the publish the delivery method and make it available to customers. When the product is in stock, a location selector is displayed on :doc:`product <../products>` and
	:doc:`checkout <checkout>` pages.

I would also put the second sentence in a note (the one mentioning the location selector, without the bold)

[auva-odoo]

On line 120 you say that if the product is out of stock, users can't select a location. I'm a bit confused on how they could even proceed to complete the checkout process without selecting a location in the first place. As is, this list item sounds very similar to the list item on line 120. If they're not the same, we might want to clarify the distinction (and maybe group the two list items together to avoid repetitions).

[auva-odoo]

I can't comment on those lines but lines 90-91 need to be updated (see my comment on line 140 as well):

- use the :guilabel:`Availability` tab to restrict the delivery method's availability;