Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] accounting: update payment matching feature #11607

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

afma-odoo
Copy link
Contributor

task-3518648

@robodoo
Copy link
Collaborator

robodoo commented Dec 19, 2024

Pull request status dashboard

@afma-odoo afma-odoo requested a review from a team December 19, 2024 10:34
@C3POdoo C3POdoo requested a review from a team December 19, 2024 10:36
@afma-odoo afma-odoo removed the request for review from a team December 19, 2024 10:47
@afma-odoo afma-odoo force-pushed the 17.0-accounting-payments-reconcile-afma branch from e4cdfc2 to df65c56 Compare December 19, 2024 12:02
@afma-odoo afma-odoo requested a review from a team December 19, 2024 12:23
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @afma-odoo! I only have a few minor comments/suggestions (and one question as well) 🙂

Comment on lines +84 to +85
The invoice or bill is now marked as :guilabel:`In payment` until it is :doc:`reconciled
<bank/reconciliation>` with its corresponding :doc:`bank transactions <bank/transactions>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The invoice or bill is now marked as :guilabel:`In payment` until it is :doc:`reconciled
<bank/reconciliation>` with its corresponding :doc:`bank transactions <bank/transactions>`.
The invoice or bill is then marked as :guilabel:`In payment` until it is :doc:`reconciled
<bank/reconciliation>` with its corresponding :doc:`bank transactions <bank/transactions>`.

Comment on lines +92 to +94
The :guilabel:`Payments matching` or :guilabel:`Auto-reconcile` tool displays all unreconciled
customer invoices and vendor bills, allowing payments to be matched with invoices or bills
individually or all at once in a single centralized location. To do so, follow these steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The :guilabel:`Payments matching` or :guilabel:`Auto-reconcile` tool displays all unreconciled
customer invoices and vendor bills, allowing payments to be matched with invoices or bills
individually or all at once in a single centralized location. To do so, follow these steps:
The :guilabel:`Payments matching` or :guilabel:`Auto-reconcile` tool allows to match payments with unreconciled customer invoices or vendor bills either individually or in batches. To do so, follow these steps:

customer invoices and vendor bills, allowing payments to be matched with invoices or bills
individually or all at once in a single centralized location. To do so, follow these steps:

#. Go to the :guilabel:`Accounting Dashboard`, click the :icon:`fa-ellipsis-v`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#. Go to the :guilabel:`Accounting Dashboard`, click the :icon:`fa-ellipsis-v`
#. Access the :guilabel:`Accounting Dashboard`, click the :icon:`fa-ellipsis-v`

Comment on lines +100 to +102
#. Search for the contact.
#. In the :guilabel:`Journal Items to reconcile` list, click :guilabel:`Auto-Reconcile` next to the
receivable or payable account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#. Search for the contact.
#. In the :guilabel:`Journal Items to reconcile` list, click :guilabel:`Auto-Reconcile` next to the
receivable or payable account.
#. Search for the contact in the :guilabel:`Journal Items to reconcile` list.
#. Click :guilabel:`Auto-Reconcile` next to the receivable or payable account.
  • Since we're already on the list when looking for a contact (and only mentioning that list after searching for the contact got me a bit confused)
  • Probably a stupid question but is searching for a contact really necessary? If not, maybe we could remove that line and rephrase the second one to say that you can also choose to reconcile all journal items for a specific account, rather than limiting it to items associated with a specific contact for that account, if that makes sense?
    image

Something like: Click :guilabel:Auto-Reconcile next to the receivable or payable account (or a specific contact's journal items in that account). --> I'm really not sure about the part between brackets but this was just to illustrate what I meant

Comment on lines +103 to +106
#. In the :guilabel:`Find Entries to Reconcile Automatically` window, Odoo has automatically
prefilled the :guilabel:`From`, :guilabel:`To`, :guilabel:`Reconcile`, :guilabel:`Accounts`,
:guilabel:`Partners` fields.
#. Click :guilabel:`Launch`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#. In the :guilabel:`Find Entries to Reconcile Automatically` window, Odoo has automatically
prefilled the :guilabel:`From`, :guilabel:`To`, :guilabel:`Reconcile`, :guilabel:`Accounts`,
:guilabel:`Partners` fields.
#. Click :guilabel:`Launch`.
#. In the :guilabel:`Find Entries to Reconcile Automatically` window, click :guilabel:`Launch`.

If there's no real step to take here, I would not mention the field. However, I think we could maybe talk about bit more about the two options for the Reconcile field? Would that make sense?

Matching invoices and bills with payments
-----------------------------------------
For a single invoice or bill
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

A blue banner appears when validating a new invoice/bill and an **outstanding payment** exists for
this specific customer or vendor. To match it with the invoice or bill, click :guilabel:`ADD`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this specific customer or vendor. To match it with the invoice or bill, click :guilabel:`ADD`
this specific customer or vendor. To match it with the invoice or bill, click :guilabel:`Add`

Comment on lines +108 to +110
Invoices and bills are automatically matched to their corresponding payments and are now marked as
:guilabel:`In payment` until it is :doc:`reconciled <bank/reconciliation>` with their corresponding
:doc:`bank transactions <bank/transactions>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Invoices and bills are automatically matched to their corresponding payments and are now marked as
:guilabel:`In payment` until it is :doc:`reconciled <bank/reconciliation>` with their corresponding
:doc:`bank transactions <bank/transactions>`.
Invoices and bills are automatically matched to their corresponding payments and are then marked as
:guilabel:`In payment` until they are :doc:`reconciled <bank/reconciliation>` with their corresponding
:doc:`bank transactions <bank/transactions>`.

Comment on lines +128 to +130
The invoices or bills are now marked as :guilabel:`In payment` until they are :doc:`reconciled
<bank/reconciliation>` with the corresponding :doc:`bank transactions <bank/transactions>`. The
credit notes or refunds are marked as :guilabel:`Paid`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The invoices or bills are now marked as :guilabel:`In payment` until they are :doc:`reconciled
<bank/reconciliation>` with the corresponding :doc:`bank transactions <bank/transactions>`. The
credit notes or refunds are marked as :guilabel:`Paid`.
The invoices or bills are then marked as :guilabel:`In payment` until they are :doc:`reconciled
<bank/reconciliation>` with the corresponding :doc:`bank transactions <bank/transactions>`. The
credit notes or refunds are marked as :guilabel:`Paid`.

Comment on lines +173 to +174
next step is :doc:`reconciling <bank/reconciliation>` it with the related :doc:`bank transactions
<bank/transactions>` line to finalize the payment workflow and mark the invoice or bill as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
next step is :doc:`reconciling <bank/reconciliation>` it with the related :doc:`bank transactions
<bank/transactions>` line to finalize the payment workflow and mark the invoice or bill as
next step is :doc:`reconciling <bank/reconciliation>` it with the related :doc:`bank transaction
<bank/transactions>` line to finalize the payment workflow and mark the invoice or bill as

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants