[FIX] theme_*: fix s_big_number wrong gradient implementation
#930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
stefanorigano
requested changes
Sep 22, 2024
There was a problem hiding this comment.
Thanks @chgo-odoo .
One remark for theme_anelusia, ok the rest 👍
chgo-odoo
force-pushed
the
master-fix-s_big_number-gradient-chgo
branch
from
bce7e21 to
57c25bc
Compare
|
Thanks @stefanorigano, change done ! Marked this as ready for review as the diff was only about a suggestion |
stefanorigano
requested changes
Sep 22, 2024
There was a problem hiding this comment.
One remark in the code.
Also, PR's description ( odoo/odoo#180983 as well):
- Typo: "This
commit" -> "This pull request" - List linked PRs at end of the description, not in the middle ;)
Thanks
chgo-odoo
force-pushed
the
master-fix-s_big_number-gradient-chgo
branch
from
57c25bc to
f0ee2e9
Compare
stefanorigano
approved these changes
Sep 23, 2024
chgo-odoo
force-pushed
the
master-fix-s_big_number-gradient-chgo
branch
from
f0ee2e9 to
a745281
Compare
*: anelusia, artists, avantgarde, aviato, beauty, bewise, bistro, bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano, notes, odoo_experts, orchid, paptic, real_estate, treehouse, vehicle, yes, zap This commit aims to fix a wrong implementation of gradients on the `s_big_number` snippet within the context of the web editor. Prior to this commit, the `s_big_number` snippet was using a gradient composed of the right color, but being declared as `RGB` values. While this is working as expected and looking like it uses the right `--o-color-*`, it's indeed working with the specific color applied in first place. If a user changes the color palette of the website, the snippet will look terrible as it doesn't adapt to the new palette. This commit fixes the issue by using the right implementation with CSS variables. It also reviews a wrong structure using `<div>` while it should use the right html tag. task-4202371
chgo-odoo
force-pushed
the
master-fix-s_big_number-gradient-chgo
branch
from
a745281 to
3d1fc22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*: anelusia, artists, avantgarde, aviato, beauty, bewise, monglia, vehicle
This PR aims to fix a wrong implementation of gradients on the
s_big_numbersnippet within the context of the web editor.Prior to this commit, the
s_big_numbersnippet was using a gradient composed of the right color, but being declared asRGBvalues.While this is working as expected and looking like it uses the right
--o-color-*, it's indeed working with the specific color applied in first place. If a user changes the color palette of the website, the snippet will look terrible as it doesn't adapt to the new palette.This PR fixes the issue by using the right implementation with CSS variables.
task-4202371
s_big_numberwrong gradient implementation odoo#180983