Bug fixes for wgpu.js #4960
Merged
Bug fixes for wgpu.js #4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimhub
commented
Mar 23, 2025
| const dynamicOffsets = this.array( | ||
| dynamicOffsetCount, | ||
| dynamicOffsetsPtr, | ||
| (ptr) => this.mem.loadU32(ptr), |
There was a problem hiding this comment.
I'm not even going to try to understand the javascript quirks that make it so this works, but just this.mem.loadU32 does not, but this is what I had to do to get it working.
jimhub
commented
Mar 23, 2025
| @@ -3087,7 +3097,7 @@ class WebGPUInterface { | |||
| * @param {number} surfaceCapabilitiesPtr | |||
| */ | |||
| wgpuSurfaceCapabilitiesFreeMembers: (surfaceCapabilitiesPtr) => { | |||
| const off = this.struct(capabilitiesPtr); | |||
| const off = this.struct(surfaceCapabilitiesPtr); | |||
There was a problem hiding this comment.
Typo with param name.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small bug fixes for wgpu.js as I was working through a somewhat involved renderer.