Use modules' fishing loot tables to randomly override fished items #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fishing event handler to the base$1.0 - \sum\text{of chances in the module's selected loot table}$ .
Module
class that rerolls one of the three fish loot categories (independently from the result got from the original vanilla roll, so skewing the effective probabilities) with weights that should emulate vanilla behavior (taking into account the player's Luck effect, Luck Of The Sea enchantment, and whether the fishing bobber is currently in open water) and randomly selects an item from the module's corresponding loot table proportional to its chance to replace the original fished item or preserves the original item with a chance ofFixes #292