Add promise support #258
Closed
Add promise support #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| globalObject.Promise.hasOwnProperty("resolve") && | ||
| globalObject.Promise.hasOwnProperty("reject") && | ||
| globalObject.Promise.hasOwnProperty("all") && | ||
| globalObject.Promise.hasOwnProperty("race") && |
There was a problem hiding this comment.
Why are you testing for all these methods on Promise? You use exactly none of them!
Drop lines 23-30.
EDIT: Drop lines 25-30
|
@mikedeboer see #262, I think it is the better solution. |
|
See #262 for a better implementation |
|
Hey folks, we plan to drop support for the custom Promise option altogether. If that causes any trouble for you, could you please let me know at #622? Thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds promise support when no callback is given.