Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make contextAttemptKey its own type. #4

Closed
wants to merge 1 commit into from
Closed

fix: Make contextAttemptKey its own type. #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions retry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,18 +118,18 @@ func Abort(err error) Error {
return permanentError{err}
}

var contextAttemptKey struct{}
type ctxKey struct{}

func withAttempt(ctx context.Context, attempt int) context.Context {
return context.WithValue(ctx, contextAttemptKey, attempt)
return context.WithValue(ctx, ctxKey{}, attempt)
}

// Attempt returns the number of previous attempts. In other words, it returns
// the zero-based index of the request.
//
// Only call this function from within a retried function.
func Attempt(ctx context.Context) int {
i := ctx.Value(contextAttemptKey)
i := ctx.Value(ctxKey{})
if i == nil {
return 0
}
Expand Down