Skip to content

[wasm] Option to implement OCaml strings with JavaScript strings - #1772

Draft
vouillon wants to merge 27 commits into
masterfrom
js-strings
Draft

[wasm] Option to implement OCaml strings with JavaScript strings#1772
vouillon wants to merge 27 commits into
masterfrom
js-strings

Conversation

@vouillon

@vouillon vouillon commented Dec 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • Conditional compilation of Wasm runtime
  • Import string constants (define JS strings in Wasm runtime)
  • default should be not to use js strings
  • Compatibilty for when JS string builtins proposal is not available
  • Performance improvements
    • skip conversions for ASCII strings
    • lower level version of caml_blit_string
    • Use I16 array for conversions
    • Remove unnecessary conversion
  • clean-up / check for missing tests
  • adapt Jane street libraries
  • performance measurements

@vouillon vouillon added the wasm label Dec 17, 2024
@vouillon
vouillon force-pushed the js-strings branch 19 times, most recently from 7622533 to 1e6911d Compare December 20, 2024 18:03
@smorimoto
smorimoto requested a review from Copilot December 29, 2024 20:07
Copilot AI reviewed Dec 29, 2024
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.

@vouillon vouillon mentioned this pull request Jan 30, 2025
Merged
@vouillon
vouillon force-pushed the js-strings branch 4 times, most recently from 2185d26 to 759358a Compare February 21, 2025 18:24
vouillon and others added 27 commits August 27, 2025 14:46
@vouillon @OlivierNicole
Wasm_of_ocaml: support JavaScript strings in prelude code
f73499f
@vouillon @OlivierNicole
Flag use-js-string default to false for wasm_of_ocaml
089cbc0
@vouillon @OlivierNicole
CI: use node v8 canary
0195b26
@vouillon @OlivierNicole
Wat file preprocessor: support use-js-string
d7ca177
@vouillon @OlivierNicole
Wasm_of_ocaml: implement use-js-string flag
4f3d492
@vouillon @OlivierNicole
Test: enable JS string
8f56d62
@vouillon @OlivierNicole
Revert "Flag use-js-string default to false for wasm_of_ocaml"
1c68684 
This reverts commit a0133d0.
@OlivierNicole
testing
08a0653
@OlivierNicole
fixes after rebase
ee77162
@vouillon @OlivierNicole
CR: fixes
e538266
@OlivierNicole
fix
1fbf5ad
@vouillon @OlivierNicole
CR: Fixes
253fed5
@OlivierNicole
Fixes and pin packages that require adaptations
4faa126
@OlivierNicole
CR: Fixes
4ec510a
@OlivierNicole
Re-enable benchmarks and promote test
3a0e5b5
@OlivierNicole
Fix CI
bbebbfd
@OlivierNicole
FIX: Temporarily disable CAMLboy benchmark
7872e22
@OlivierNicole
Fix error in rebase
02f94c1
@OlivierNicole
[TMP] Reinstate caml_utf16_of_utf8 and its inverse
b33001f
@OlivierNicole
Improve error reporting in benchmark-ocamlc/
d7ca7b1
@OlivierNicole
[TMP] Re-enable CAMLboy and disable buggy PRT benchmark
f3d3651
@OlivierNicole
Fix CAMLboy
d4bbd0b
@OlivierNicole
Fix caml_hash_mix_string/bytes
879f79d
@OlivierNicole
Re-enable partial_render_table bench
afad00c
@OlivierNicole
Fix...
e817f46
@OlivierNicole
Integrate bin_prot benchmark into JS packages pins
98c53ff
@OlivierNicole
Remove comment in Makefile
3f33f93
@OlivierNicole

OlivierNicole commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Rebased on master.

@hhugo

hhugo commented Jul 2, 2026

Copy link
Copy Markdown
Member

@vouillon, What should we do about this PR ?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hhugo hhugo hhugo left review comments
@OlivierNicole OlivierNicole OlivierNicole left review comments
Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

wasm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vouillon @OlivierNicole @hhugo