Add boot_uid to device. #1335
Open
Add boot_uid to device. #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmadison
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
hmadison
force-pushed
the
hm/add-boot-uid
branch
2 times, most recently
from
ec22f10 to
5a9103d
Compare
floydtree
requested changes
Feb 4, 2025
On Linux systems, the procfs contains a unique per-boot identifier. Certain tools, such as EDR platforms or journald logs contain this identifier in their emitted telemerty. From an analytical perspective, it's useful to extract since it provides an analyst the ability to see activity from a given system across multiple reboots. For more details see: `man 3 sd_id128_get_machine()` Signed-off-by: Hunter Madison <[email protected]>
hmadison
force-pushed
the
hm/add-boot-uid
branch
from
5a9103d to
a2c7359
Compare
mlmitch
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Good stuff. We use boot identification in CPID calculation.
https://github.com/ocsf/common-process-id/blob/main/specification.md
objects/device.json
Outdated
| @@ -130,6 +130,10 @@ | |||
| "vendor_name": { | |||
| "description": "The vendor for the device. For example <code>Dell</code> or <code>Lenovo</code>.", | |||
| "requirement": "recommended" | |||
| }, | |||
| "boot_uid": { | |||
| "description": "A unique identifier of the device that changes after every reboot. For example, the value of <code>/proc/sys/kernel/random/boot_id</code> from Linux's procfs.", | |||
There was a problem hiding this comment.
You don't need to duplicate the description here because it is already defined in the dictionary.
| @@ -401,6 +401,11 @@ | |||
| "description": "The time when the system was booted.", | |||
| "type": "timestamp_t" | |||
| }, | |||
| "boot_uid": { | |||
| "caption": "Boot UID", | |||
| "description": "A unique identifier of the device that changes after every reboot. For example, the value of <code>/proc/sys/kernel/random/boot_id</code> from Linux's procfs.", | |||
There was a problem hiding this comment.
link/reference to kernel docs would be nice
https://docs.kernel.org/admin-guide/sysctl/kernel.html#random
floydtree
requested changes
Feb 4, 2025
| }, | ||
| "boot_uid": { | ||
| "requirement": "optional", | ||
| "references": [ |
There was a problem hiding this comment.
would be good to add references in the dictionary itself
|
|
||
| ### Improved | ||
| * #### Objects | ||
| 1. Added `boot_uid` to `device` objects. |
There was a problem hiding this comment.
nit: s/objects/object
Also for both the entries, add the PR number. No need to add a link, just the #number will suffice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Description of changes:
On Linux systems, the procfs contains a unique per-boot identifier. Certain tools, such as EDR platforms or journald logs contain this identifier in their emitted telemetry. From an analytical perspective, it's useful to extract since it provides an analyst the ability to see activity from a given system across multiple reboots.
For more details see:
man 3 sd_id128_get_machine()