Apply suggestions from code review

Signed-off-by: Paul Bastide <[email protected]>
ocp-power-automation · May 20, 2024 · c4216f3 · c4216f3
1 parent 943dffe
commit c4216f3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 16 deletions.
diff --git a/tf/add-powervm-workers/README.md b/tf/add-powervm-workers/README.md
@@ -2,7 +2,7 @@
 
 User need to uopdate required vales in data/vars.tfvars file such as username and password of IBM intranet credentials to get access to the PowerVC.
 ```
-auth_url                    = "https://scnlonprema.pokprv.stglabs.ibm.com:5000/v3/"
+auth_url                    = "https://host.net:5000/v3/"
 user_name                   = "***@us.ibm.com"
 password                    = "***"
 ```

diff --git a/tf/add-powervm-workers/powervm.tfvars b/tf/add-powervm-workers/powervm.tfvars
@@ -3,18 +3,21 @@
 # SPDX-License-Identifier: Apache-2.0
 ################################################################
 
-auth_url                    = "https://scnlonprema.pokprv.stglabs.ibm.com:5000/v3/"
-user_name                   = "***@us.ibm.com"
-password                    = "***"
-ignition_ip                 = "10.20.29.41"
-resolver_ip                 = "10.20.29.41"
-resolve_domain              = ""
-insecure                    = true
-tenant_name                 = "base-ocp"
-domain_name                 = "Default"
-network_name                = "vlan1337"
-power_worker_prefix         = "power-worker-"
-flavor_id                   = "29fcd15b-c41c-4b9b-90b7-43bbf914c2df"
-image_id                    = "3f877d0e-84e8-41fe-988d-318ea1521b0a"
-openstack_availability_zone = "e980"
-worker_count                = 2
+auth_url    = "https://<PowerVC-Host>:5000/v3/"
+user_name   = "<EMAIL>"
+password    = "<PASSWORD>"
+insecure    = true
+tenant_name = "<PROJECT>"
+domain_name = "<DOMAIN>"
+
+network_name                = "<NETWORK>"
+ignition_ip                 = "<IP>"
+resolver_ip                 = "<IP>"
+resolve_domain              = "<domain for resolver dns>"
+power_worker_prefix         = "<prefix-for-power-workers>"
+flavor_id                   = "<flavor_id>"
+image_id                    = "<image_id>"
+openstack_availability_zone = "<host group>"
+
+# the number of workers to create
+worker_count = 2