Skip to content

Update the readme that MSA accounts are fine closes #96 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mitchcapper
Copy link
Collaborator

@vladdypwnz pointed out the documentation is confusing about MSA accounts not working. I tested one and it seemed fine, are the docs are out of date or am I missing something else?

@vlad-at-work
Copy link

I think maybe mention that the live: prefix doesn't actually mean much? Even without it, myaccountname won't work because the account username is actually [email protected] - this was the source of my confusion.

@mitchcapper
Copy link
Collaborator Author

Ah the live: prefix would not be for logging in but returned on the account type itself. You do need to use the full MSA login (ie [email protected]) if not using older skype only usernames.

@vlad-at-work
Copy link

@mitchcapper Right, I was suggesting that maybe that's worth including in this PR because it's not entirely obvious for the uninitiated 😀 (as long as that section is being updated anyway)

@mitchcapper
Copy link
Collaborator Author

mitchcapper commented Apr 26, 2018

@vladdypwnz I am actually having a hard time finding where you saw the live: prefixing. I read the readme, checked the ts file docs for login, and even the old generated docs. Where were you seeing it?

@vlad-at-work
Copy link

vlad-at-work commented Apr 26, 2018

@mitchcapper I naively assumed it would show up properly in Skype itself. I think the live prefix is new to the most recent version of Skype. Here's what the profile for the test account looks like: (keep in mind that vladcansignup in this case, even without live:, is still not a valid username)

screen shot 2018-04-26 at 11 55 02 am

@mitchcapper mitchcapper force-pushed the update_readme_allow_msas_pr branch from e9cb865 to b0c0e14 Compare April 26, 2018 19:02
@mitchcapper mitchcapper force-pushed the update_readme_allow_msas_pr branch from b0c0e14 to 642f7df Compare April 26, 2018 19:03
@mitchcapper
Copy link
Collaborator Author

OK I updated the PR to add a sample under quickstart for an MSA login, beyond that while MS shows MSA's with the live: prefix as when you login to skype it still requires [email protected] for the login flow I think it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants