add .transpire.py #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turtlebasket
suggested changes
Mar 6, 2025
.transpire.py
Outdated
|
|
||
| ing = Ingress.from_svc( | ||
| svc = svc, | ||
| host = "//rt.ocf.berkeley.edu", |
.transpire.py
Outdated
| @@ -0,0 +1,78 @@ | |||
| from tkinter.filedialog import Directory | |||
Member
There was a problem hiding this comment.
this should not depend on tkinter
Contributor
Author
There was a problem hiding this comment.
i lowkey do not know how that got there.
Member
There was a problem hiding this comment.
L43:
dep.obj.spec.template.spec.volumes = [
client.V1Volume(
name = "secrets",
host_path = { "path": "/opt/share/kubernetes/secret/rt", "type": "Directory" } # <---
),
]may have been auto-imported by LSP if you hit tab at the wrong time lol
|
|
||
| name = "rt" | ||
| auto_sync = True | ||
|
|
Member
There was a problem hiding this comment.
no images are yielded anywhere; that needs to be in here somewhere (def images())
Contributor
Author
There was a problem hiding this comment.
wait how can i check ghcr to make sure it has the image i want to yield
oliver-ni
reviewed
Mar 6, 2025
.transpire.py
Outdated
| def objects(): | ||
| svc = Service( | ||
| name = "rt", | ||
| selector = { |
Member
There was a problem hiding this comment.
selector=dep.get_selector(),and put under
oliver-ni
reviewed
Mar 6, 2025
.transpire.py
Outdated
| # set the volumes in the Deployment | ||
| dep.obj.spec.template.spec.volumes = [ | ||
| client.V1Volume( | ||
| name = "secrets", |
Member
There was a problem hiding this comment.
can we remove the spaces around the =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be a 1:1 translation