Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put event object within indexedMetadata from new DDO structure. #824

Merged
merged 9 commits into from
Feb 10, 2025

Conversation

mariacarmina
Copy link
Member

Fixes #526 .

Changes proposed in this PR:

  • Put event object within indexedMetadata from new DDO structure.

@mariacarmina mariacarmina self-assigned this Jan 27, 2025
@mariacarmina
Copy link
Member Author

mariacarmina commented Jan 27, 2025

CLI download failed with:

Error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"id\":125,\"jsonrpc\":\"2.0\",\"error\":{\"message\":\"VM Exception while processing transaction: revert Invalid provider fee\",\"stack\":\"RuntimeError: VM Exception while processing transaction: revert Invalid provider fee\\n    at exactimate (/app/dist/node/1.js:2:166011)\",\"code\":-32000,\"name\":\"RuntimeError\",\"data\":{\"hash\":null,\"programCounter\":43,\"result\":\"0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000014496e76616c69642070726f766964657220666565000000000000000000000000\",\"reason\":\"Invalid provider fee\",\"message\":\"revert\"}}}"

Need to check the provider fee setting from ocean-cli.

EDIT: Didn't occur

@mariacarmina mariacarmina marked this pull request as ready for review January 31, 2025 14:15
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
(PS: we might have some issues regarding fees, on the other branch)

@mariacarmina mariacarmina merged commit 2bc4f73 into feature/new-ddo-structure Feb 10, 2025
8 checks passed
@mariacarmina mariacarmina deleted the feature/new-event branch February 10, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants