Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new compute envs specs #802

Merged
merged 19 commits into from
Jan 23, 2025
Merged

new compute envs specs #802

merged 19 commits into from
Jan 23, 2025

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Jan 14, 2025 •
edited
Loading

Fixes #801

Changes proposed in this PR:

  • new compute env specs/structures
  • account for incoming legacy stuff (do struct conversion if needed, for instance from operator service)

@paulo-ocean paulo-ocean changed the title first draft new envs new compute envs specs Jan 14, 2025
@paulo-ocean paulo-ocean self-assigned this Jan 20, 2025
@paulo-ocean paulo-ocean marked this pull request as ready for review January 20, 2025 13:04
@paulo-ocean paulo-ocean marked this pull request as draft January 20, 2025 13:05
@paulo-ocean paulo-ocean marked this pull request as ready for review January 20, 2025 15:00
alexcos20
alexcos20 requested changes Jan 22, 2025
View reviewed changes
src/components/c2d/index.ts Outdated Show resolved Hide resolved
src/components/c2d/index.ts Outdated Show resolved Hide resolved
src/components/core/utils/feesHandler.ts Outdated Show resolved Hide resolved
src/test/integration/compute.test.ts Outdated Show resolved Hide resolved
@alexcos20
Copy link
Member

You can remove all code related to old k8 c2d if needed. including tests for that

@alexcos20 alexcos20 merged commit d8913bc into feature/c2d_docker Jan 23, 2025
8 checks passed
@alexcos20 alexcos20 deleted the issue-801-env-specs branch January 23, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 requested changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulo-ocean @alexcos20