#797 - DCV_J should be in OCEAN #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trizin
commented
Feb 6, 2024
|
|
||
| stakes = {C1: {NA: {LP1: 1e6}}} | ||
| nftvols = {C1: {OCN_ADDR: {NA: DCV_USD}}} | ||
| nftvols = {C1: {OCN_ADDR: {NA: DCV_OCEAN}}} |
There was a problem hiding this comment.
Note: Reward calculator expects volumes to be in the token used to purchase the asset and later converts it to USD.
|
Code Climate has analyzed commit 5951384 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 92.7% (0.0% change). View more on Code Climate. |
|
Please ignore the failing "Dispense Active Rewards" failure, it is failing because "https://safe-transaction-goerli.safe.global" is down. |
trentmc
approved these changes
Feb 6, 2024
trizin
deleted the
issue797-dcv_j-is-in-usd-and-being-used-to-limit-the-max-ocean
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #797
Changes proposed in this PR: