Collect compaction_low_thread_score in compaction diagnostics - #1250
Open
wayyoungboy wants to merge 1 commit into
Open
Collect compaction_low_thread_score in compaction diagnostics#1250wayyoungboy wants to merge 1 commit into
wayyoungboy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1237.
Adds
compaction_low_thread_scorecollection to both compaction diagnostics paths:observer.compactiongather now collects the parameter fromoceanbase.__all_virtual_tenant_parameter_info, ordered by tenant and server scope, so all tenant/server values are included.rca major_holdnow records and savescompaction_low_thread_scoreat the start of the diagnosis.The RCA records value
0as OceanBase using the internal default thread score instead of treating it as an error.Verification
Results:
test_major_hold_compaction_thread_score.py: 2 passedtest_scene.py: 17 passed