Skip to content

[WIP] Add Cloud Anchors to G2O Optiization #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Add Cloud Anchors to G2O Optiization #25

wants to merge 3 commits into from

Conversation

ayushchakra
Copy link
Contributor

No description provided.

richardli03
richardli03 previously approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@richardli03 richardli03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

run_scripts/optimize_graphs_and_manage_cache.py

if args.ca and (args.pso == PrescalingOptEnum.USE_SBA.value or not args.s):
raise ValueError(
"Cloud Anchors are currently only supported in no SBA parameter sweeps"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation!

Base automatically changed from rawr_work_branch to master June 9, 2023 14:57
@ayushchakra ayushchakra dismissed richardli03’s stale review June 9, 2023 14:57

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardli03 richardli03 richardli03 approved these changes

@paulruvolo paulruvolo Awaiting requested review from paulruvolo

@ruchadave16 ruchadave16 Awaiting requested review from ruchadave16

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushchakra @richardli03 @redhotchili0909