Skip to content

Named targets feature #11653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

create2000
Copy link

This is the first of two commits implementing named targets support, as discussed in #3309

Changes in this PR:

  • Adds support for (targets (:name file) ...) syntax
  • Defines Static.named type in Targets_spec
  • Parses bindings without changing evaluation logic
  • Verifies syntax with parse tests

Coming Next:
The second commit will implement the actual variable expansion and validation:

  1. Target variable resolution (%{target:name})
  2. Duplicate name prevention
  3. Full integration with action expansion

Test Plan:

  • Verify existing tests pass
  • Added syntax parsing tests

@gridbugs
Copy link
Collaborator

Just clarifying that we won't be able to merge this PR until it contains both the parser for the new named targets syntax and the ability to resolve named targets. I like the idea of keeping these two stages separate for ease of implementation/review, so keeping them as separate commits in the same PR makes sense (I can review them commit-by-commit rather than reviewing the entire PR at once).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants