Skip to content

config: enable build progress by default #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

config: enable build progress by default #11510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions boot/configure.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ let out =
;;

let default_toggles : (string * [ `Disabled | `Enabled ]) list =
[ "toolchains", `Enabled; "pkg_build_progress", `Disabled; "lock_dev_tool", `Disabled ]
[ "toolchains", `Enabled; "pkg_build_progress", `Enabled; "lock_dev_tool", `Disabled ]
;;

let toggles = ref default_toggles
Expand Down Expand Up @@ -94,8 +94,7 @@ let () =
user-wide directory." )
; ( "--pkg-build-progress"
, toggle "pkg_build_progress"
, " Enable the displaying of package build progress.\n\
\ This flag is experimental and shouldn't be relied on by packagers." )
, " Enable the displaying of package build progress.")
; ( "--lock-dev-tool"
, toggle "lock_dev_tool"
, " Enable ocamlformat dev-tool, allows 'dune fmt' to build ocamlformat and use \
Expand Down
1 change: 0 additions & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
add-experimental-configure-flags = pkg: pkg.overrideAttrs {
configureFlags =
[
"--pkg-build-progress" "enable"
"--lock-dev-tool" "enable"
];
};
Expand Down
2 changes: 1 addition & 1 deletion src/dune_rules/setup.defaults.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ let roots : string option Install.Roots.t =

let prefix : string option = None
let toolchains = `Enabled
let pkg_build_progress = `Disabled
let pkg_build_progress = `Enabled
let lock_dev_tool = `Disabled
Loading