Skip to content

Disable Lin Bytes test under OCaml 5.2 and earlier #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Mar 31, 2025

The weekly runs this morning caused all 5.2.0 runs to fail the Lin Bytes test.

This was an omission from #546:

The new improved ™️ Thread mode utilizes Gc.Memprof support to trigger context switching. 5.3 restored Memprof, which means the thread test works well there and on trunk - both tested by CI on PRs.
I tested locally on 5.2 at some point and then forgot about it again. Given the above, I think the Lin Thread-mode test of Bytes should just be disabled on 5.2 and earlier.

This PR does exactly that.

Copy link
Collaborator

@shym shym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jmid jmid merged commit 2cd3876 into main Apr 1, 2025
36 checks passed
@jmid
Copy link
Collaborator Author

jmid commented Apr 1, 2025

CI summary: all 36 workflows passed

@jmid
Copy link
Collaborator Author

jmid commented Apr 1, 2025

CI summary for merge to main: all 37 workflows passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants