Skip to content

Clarify test suite recommendations in README #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

Clarify test suite recommendations in README #545

merged 4 commits into from
Mar 28, 2025

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Mar 28, 2025

As a follow-up to #541 this PR clarifies some of the requirements and recommendations

  • the need for a multicore machine
  • a recommendation to run the test suite tests one-after-another

Finally, as I find myself maintaining this repo, I'm using this opportunity to also tone down that aspect of the README's last line. CC: @shym

shym
shym approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@shym shym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jmid
Copy link
Collaborator Author

jmid commented Mar 28, 2025

CI summary:

Out of 36 workflows 1 timed out with a false alarm

@jmid jmid merged commit 3a1d2d3 into main Mar 28, 2025
35 of 36 checks passed
@jmid jmid deleted the testsuite-clarify branch March 28, 2025 15:34
@jmid
Copy link
Collaborator Author

jmid commented Mar 28, 2025

CI summary for merge to main: all 37 workflows passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shym shym shym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmid @shym