Skip to content

Reenable Gc.compact in Gc tests #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

Reenable Gc.compact in Gc tests #508

merged 3 commits into from
May 21, 2025

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jan 9, 2025

This one-line PR is a left-over from #469. It was omitted from that one to move forward with the Gc tests.

I expect the PR to trigger the two outstanding Gc issues:

To avoid introducing noise in CI runs, it should be merged once these two have been resolved.

@jmid
Copy link
Collaborator Author

jmid commented Jan 9, 2025

CI summary:

These were as expected.

Out of 33 workflows 3 failed with genuine issues.

@jmid jmid force-pushed the gc-test-enable-compact branch from 0a6b2ed to c592e05 Compare February 4, 2025 14:15
@jmid
Copy link
Collaborator Author

jmid commented Feb 4, 2025

Dummy push to trigger a fresh CI rerun with the fix of ocaml/ocaml#13090 merged

@jmid
Copy link
Collaborator Author

jmid commented Feb 4, 2025

CI summary for c592e05

The latter is expected as #470 has now been fixed on trunk but will continue to trigger on 5.3.

Out of 34 workflows, 1 failed with a genuine error and 2 with false alarms

@jmid jmid force-pushed the gc-test-enable-compact branch from c592e05 to dcb978b Compare March 1, 2025 15:19
@jmid
Copy link
Collaborator Author

jmid commented May 20, 2025

CI summary for dcb978b:

  • Linux 5.3 debug failed in STM Gc stress test parallel with an assertion error local->stats.pool_live_words == pool_stats.live [ocaml5-issue] Assertion failure on live words in GC test #470
  • OPAM installation / build-and-test (ocaml-variants.5.4.0+trunk) failed to install dune.3.17.2 due to a trunk incompatibility

Out of 36 workflows 2 failed with genuine errors.

@jmid jmid force-pushed the gc-test-enable-compact branch from dcb978b to 0a43592 Compare May 20, 2025 15:54
@jmid
Copy link
Collaborator Author

jmid commented May 20, 2025

I've just

  • rebased on main,
  • added a guard to Gc.compact in 404dd17, and
  • added the issue to the README list

@jmid
Copy link
Collaborator Author

jmid commented May 21, 2025

CI summary for 0a43592

Out of 51 workflows 1 failed with a borderline defect/reliability issue

@jmid jmid merged commit 69b8bf3 into main May 21, 2025
50 of 51 checks passed
@jmid jmid deleted the gc-test-enable-compact branch May 21, 2025 05:55
@jmid
Copy link
Collaborator Author

jmid commented May 21, 2025

CI summary for merge to main:

Out of 51 workflows, 1 failed with a borderline defect/reliability issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant