Disable 'Lin.Internal CList int test with Thread' under bytecode#435
Merged
Disable 'Lin.Internal CList int test with Thread' under bytecode#435
Conversation
Collaborator
Author
|
CI summary:
Out of 44 workflows, 1 failed - with a genuine issue 🎉 |
Collaborator
Author
|
CI summary for merge to main:
Out of 45 workflows, 2 failed - with genuine issues 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCaml's systhread context switching varies between the native and bytecode modes.
This is challenging to the experimental
Threadmodes and the package tests of it.As a result
Lin.Internal ref int/int64 test with Threadhave been disabled in bytecode modeLin.Internal CList int64 test with Threadhas also been disabled in bytecode modeThis left
Lin.Internal CList int test with Thread- which is marked as a positive test, but would occasionally find an unexpected counterexample in bytecode mode, causing a false alarm #358 - most recently in bothbytecode trunkruns from #434.This PR thus disables
Lin.Internal CList int test with Threadin bytecode mode too.It should eliminate another cause of false alarms.
Fixes #358