Skip to content

Add macos-latest and windows-latest #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add macos-latest and windows-latest #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf7200e
Add macos-latest and windows-latest (windows is expected to crash)
davesnx May 8, 2025
3a21a4e
set_binary_mode in stdout
davesnx May 8, 2025
aa52218
split dune builds to test windows
davesnx May 8, 2025
0558068
Remove merlin to test mlx?
davesnx May 8, 2025
9472d3f
Merge branch 'main' into add-mac-and-win-in-ci
davesnx Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
matrix:
os:
- ubuntu-latest
- macos-latest
- windows-latest

ocaml-compiler:
- "4.14"
- "5.1"
Expand All @@ -38,7 +41,7 @@ jobs:

- run: opam install . --deps-only --with-test

- run: opam exec -- dune build -p mlx,ocamlmerlin-mlx
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocamlmerlin-mlx is broken in windows, boo @andreypopp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's the crash: https://github.com/ocaml-mlx/mlx/actions/runs/18459675413/job/52588035599?pr=21 🤷 :wat:

- run: opam exec -- dune build -p mlx

# TODO: pass --with-dev-setup to opam instead? (requires opam 2.2, I think)
- run: opam install menhir.20201216 menhirLib.20201216 menhirSdk.20201216 ocamlformat
Expand Down
1 change: 1 addition & 0 deletions mlx/pp.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ let () =
if !print_ml then Format.printf "%a@." Pprintast.structure str
else
let oc = stdout in
Out_channel.set_binary_mode oc true;
output_string oc
Ppxlib_ast.Compiler_version.Ast.Config.ast_impl_magic_number;
output_value oc fname;
Expand Down
Loading