graphics-hook: Fix D3D9 memory capture regression #12794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0b87f53 added a conditional check on the shared texture handle, preventing memory capture in D3D9.
D3D10 and D3D11 use a capture struct with a union whose variants overlap in memory, so the check still accessed the union member, which worked in practice but is undefined behavior.
Fix the capture detection for D3D9 memory capture, and update the D3D10/D3D11 checks to evaluate only the active union variant to remove the undefined behavior.
Description
Motivation and Context
Fix D3D9 memory capture.
Fix C++ UB.
How Has This Been Tested?
Tested D3D9, D3D10 and D3D11 game capture with both memory and shared texture capture.
Types of changes
Checklist: