Add side panel open behavior option#622
Open
imadreamerboy wants to merge 3 commits intoobsidianmd:mainfrom
Open
Add side panel open behavior option#622imadreamerboy wants to merge 3 commits intoobsidianmd:mainfrom
imadreamerboy wants to merge 3 commits intoobsidianmd:mainfrom
Conversation
Contributor
Author
|
as we discussed in #498 i implemented the side-panel behaviour on top of your existing solution. I have not implemented a designated shortcut to open the side-panel. If we want/need that it's something i can quickly add, open for suggestions or improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the side-panel as an additional option for the opening behaviour. As part of that i reworked the background controller and funneled every entry point (toolbar, context menu, highlighter) through a single helper function, this ensures that the side panel is opened only in direct response with user gestures.
I successfully tested the functionality on Chrome, Edge, Vivaldi, Firefox.
Open behavior enhancements:
openBehaviorsetting throughout the codebase, including types, settings management, and storage utilities. [1] [2] [3] [4] [5]settings.html) and localization to allow users to select "side panel" as the default open behavior. [1] [2]Background script and browser integration:
background.tsto handle opening the Clipper UI in the side panel using the appropriate browser APIs for Chrome, Firefox, and other browsers, including error handling and fallback behaviors. [1] [2] [3] [4] [5] [6] [7] [8]Manifest and browser-specific configuration:
sidebar_actionto the Firefox manifest to enable the side panel feature in Firefox.Popup and UI logic: