Skip to content

Fixes #3640 Update eyelid textual definition #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleixpuigb wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Open

Fixes #3640 Update eyelid textual definition #3641

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af89fa1
Fixes #3640 to correctly classify eyelid as a facial skin
aleixpuigb Dec 17, 2025
9e9e4e5
Improve 'eyelid' definition to include also non-skin structures
aleixpuigb Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ontology/uberon-edit.obo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28975,7 +28975,7 @@ xref: SCTID:265782007
xref: UMLS:C0015426 {source="ncithesaurus:Eyelid"}
xref: VHOG:0000016
xref: Wikipedia:Eyelid
is_a: UBERON:0000064 ! organ part
is_a: UBERON:0000014 ! zone of skin
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reclassification of eyelid as "zone of skin" is semantically incorrect. The eyelid is a complex multi-tissue structure, not just skin.

Evidence from the ontology itself:

  1. Line 28989 documents that eyelid consists of 7 distinct layers: skin, subcutaneous connective tissue, striated muscle, submuscular connective tissue, fibrous layer, smooth muscle, and palpebral conjunctiva
  2. Line 28986 notes that "FMA divides this into skin, fascia, conjunctiva"
  3. The ontology already has a separate term "skin of eyelid" (UBERON:0001457) that is correctly classified as a "zone of skin"
  4. Parts of the eyelid include levator palpebrae superioris (muscle, line 25855) and palpebral conjunctiva (mucous membrane, line 32063)

The correct pattern is established by "prepuce" (UBERON:0011374), which is also a "fold of skin and mucous membrane":

  • Prepuce is classified as "external soft tissue zone", not "zone of skin"
  • It has "has_part" relationships to both skin and mucosa
  • Line 146065 includes a curator note: "this structure is a combination of skin and other tissue"

The eyelid should remain classified as "organ part" (UBERON:0000064) or be reclassified to something like "external soft tissue zone", with a "has_part" relationship to skin, rather than being classified directly as "zone of skin".

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@dosumis dosumis Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

relationship: capable_of GO:0060082 ! eye blink reflex
relationship: contributes_to_morphology_of UBERON:0000019 ! camera-type eye
relationship: fma_set_term FMA:75178
Expand Down
Loading