Migrate extension wallet to Manifest V3 architecture #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
lukaw3d
force-pushed
the
lw/manifest-v3-3
branch
from
76eb767 to
ef70d08
Compare
lukaw3d
changed the title
buberdds
reviewed
Jan 30, 2025
| @@ -8,7 +8,7 @@ import type { | |||
| } from '../../src/vendors/nexus/index' | |||
| import { StringifiedBigInt } from '../../src/types/StringifiedBigInt' | |||
|
|
|||
| export async function mockApi(context: BrowserContext | Page, balance: StringifiedBigInt) { | |||
| export async function mockApi(context: BrowserContext | Page, balance: number | StringifiedBigInt) { | |||
There was a problem hiding this comment.
oh I did not update all mockApi usage. this is minor and not related to this PR, but Account['available'] would be more accurate. can bump it once this is one is merged if that works for you.
buberdds
reviewed
Jan 30, 2025
buberdds
reviewed
Jan 30, 2025
buberdds
reviewed
Jan 30, 2025
lukaw3d
commented
Jan 30, 2025
src/app/state/persist/saga.ts
Outdated
Comment on lines
224
to
230
| yield* fork(function* () { | ||
| const channelQueue = yield* actionChannel<AnyAction>('*') | ||
| let previousStringifiedEncryptionKey: PersistState['stringifiedEncryptionKey'] = undefined | ||
| while (true) { | ||
| yield* take(channelQueue) | ||
| const stringifiedEncryptionKey = yield* select(selectStringifiedEncryptionKey) | ||
| if (stringifiedEncryptionKey !== previousStringifiedEncryptionKey) { | ||
| previousStringifiedEncryptionKey = stringifiedEncryptionKey | ||
| yield* call(writeSharedExtMemory, stringifiedEncryptionKey) | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| yield* fork(function* () { | ||
| const encryptedState = window.localStorage.getItem( | ||
| STORAGE_FIELD, | ||
| ) as EncryptedString<PersistedRootState> | null | ||
| if (!encryptedState) return // Ignore | ||
| try { |
There was a problem hiding this comment.
From michal: does order matter?
does look risky to write before reading the stored value from previous session
There was a problem hiding this comment.
Hm, bfe226e breaks v0 migration
There was a problem hiding this comment.
ah I lost one commit during squashing
lukaw3d
force-pushed
the
lw/manifest-v3-3
branch
4 times, most recently
from
bfe226e to
922a75d
Compare
|
Report too large to display inline |
buberdds
approved these changes
Jan 31, 2025
lukaw3d
force-pushed
the
lw/manifest-v3-3
branch
from
922a75d to
330eb29
Compare
This was referenced Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2084
Built on top of #2118
Diff vs #2084: https://github.com/oasisprotocol/wallet/compare/ca34c34d91e928ad545445648bd8152bc459c5b9..76eb7677053b22541c332b21f38237882d2cbaeb