Disallow conflicting restrictions for the same capability #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepizzo
reviewed
Oct 8, 2025
Comment on lines
117
to
124
| Services can specify a different set of restrictions specific to a path given through the | ||
| following mechanisms: | ||
| - an external annotation target of the form `ns.container/EntitySet/NavProp1/.../NavPropN` | ||
| - a navigation property path in `Capabilities.NavigationRestrictions/RestrictedProperties/NavigationProperty` | ||
| - a combination of both. | ||
|
|
||
| In these cases the more specific restrictions take precedence. It is an error to specify | ||
| conflicting restrictions of the same capability through different mechanisms. |
There was a problem hiding this comment.
Reword along the lines of:
Suggested change
| Services can specify a different set of restrictions specific to a path given through the | |
| following mechanisms: | |
| - an external annotation target of the form `ns.container/EntitySet/NavProp1/.../NavPropN` | |
| - a navigation property path in `Capabilities.NavigationRestrictions/RestrictedProperties/NavigationProperty` | |
| - a combination of both. | |
| In these cases the more specific restrictions take precedence. It is an error to specify | |
| conflicting restrictions of the same capability through different mechanisms. | |
| Services can specify a different set of restrictions specific to a resource path given through the | |
| following mechanisms: | |
| - an external annotation target of the form `ns.container/EntitySet/NavProp1/.../NavPropN` | |
| - a navigation property path formed by appending the target navigation property to the an element annotated with the NavigationRestrictions term `Capabilities.NavigationRestrictions/RestrictedProperties/NavigationProperty` | |
| - a combination of both. | |
| Restrictions specific to a path take precedence over restrictions applied directly to a containment path. It is an error to specify conflicting restrictions for the same resource path. | |
HeikoTheissen
commented
Oct 10, 2025
Comment on lines
+111
to
113
| Capabilities annotations targeting a canonical collection (in the | ||
| sense of [OData-Protocol, section 10](https://oasis-tcs.github.io/odata-specs/odata-protocol/odata-protocol.html#ContextURL)) | ||
| apply to every entity in that collection, even if it is addressed via a non-canonical path. |
There was a problem hiding this comment.
Does this also apply to Capabilities.NavigationRestrictions on an entity set where RestrictedProperties/NavigationProperty is a containment navigation property? The concatenation of entity set and navigation property is then a canonical path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298