Repository navigation
refactor: move misplaced functions to the modules that own them - #1888
Merged
Merged
Conversation
- get_repo_url and URL formatting: data/fields/url.rs -> data/git/remote.rs (shared input of the Project and URL fields) - get_git_username, get_git_version: data/git/mod.rs -> data/title.rs (only used by the title) - get_manifest: data/mod.rs -> data/manifest.rs - COLOR_PALETTE: render/style.rs -> render/colors.rs - --true-color auto resolution: cli.rs -> options.rs No behavior change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 3.0.0 restructure: a few functions and constants still lived outside the module that owns them, against the rules in
ARCHITECTURE.md. Pure moves, no behavior change.get_repo_url+ URL formatting (and tests)data/fields/url.rsdata/git/remote.rsdata::gitget_git_username,get_git_versiondata/git/mod.rsdata/title.rs(private)git --versionisn't a repository queryget_manifestdata/mod.rsdata/manifest.rsget_manifests;data/mod.rskeepsInfo,InfoOptions,build_infoCOLOR_PALETTErender/style.rsrender/colors.rscolors.rs;style.rskeepsLine/Span/Styleand the ANSI writer--true-color autoresolution (COLORTERM)cli.rsoptions.rscliis only the clap definition; turningCliintoRenderOptionsisoptions' jobTesting
cargo fmt,cargo clippy --all-targets: cleancargo test --no-fail-fast: all pass excepttest_reftable_repo_is_rejected, which also fails onmainlocally (its fixture needs git ≥ 2.45; local git is 2.43)-o jsonoutput unchanged🤖 Generated with Claude Code