Fix sources displayed in verbose output #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for your contribution ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 ,
While I tried to debug #93, I noticed the sources displayed in the verbose output were not correct.
The deprecated field
sourcefrompysentry::cli::Auditargswas displayed instead ofsources.In this PR I propose (very small) changes in
src/cli.rsto fix that.I also tried to include tests to validate the changes following the way tests are implemented. In order to do that I added to
devdependencies :assert_cmdandpredicates.As my experience with rust is small, I'm not so sure the way I fix the sources display and the tests is ok (especially the tests 😄).
Do not hesitate to give me feedbacks if the proposal is ok but you would like me to make changes !
Regards