[WIP] Add support docker compose plugin #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am using the new docker compose plugin
docker-compose-plugin
which comes bundled with docker when installing the latest version. This does not require you to install thedocker-compose
plugin manually and works as part of thedocker
command.Notes
docker-compose
which gives me the feeling it's less of an impact.docker-compose
library anymore, please test.The Makefile for this project expects to use the
docker-compose
command to bring up the project.I've added checks to determine if we can use
docker-compose
which will in turn check the docker compose API version to determine the separator (existing functionality).In case
docker-compose
was not found it will check for thedocker compose
plugin and will throw an error and exit the program if this is also not found.Some changes I made:
SEPARATOR
var to_
, which will only be overwritten to-
in case you are using a older version ofdocker-compose
. The assumption here is that the new docker compose plugin defaults to v2 or higher.DOCKER_COMPOSE_CMD
. Defaults todocker-compose
, will be overwritten ifdocker-compose
is not found and thedocker compose
plugin is detected.Related issues
None
Todo
docker-compose