add blink cmp highlight groups

[boydkelly]

Blink seems to be fast taking over nvim-cmp as the defacto completion package. The cmdline functionality is very new and there seem to be few missing pieces that might require some adjustements later (ie Match and MachFuzzy for one). Without the new highlight groups blink will use either new lor legacy groups. The new groups look ok but are black and white. The legacy groups come up very bad looking. Also blink at least for now seems to be using the kind.property icon in the cmdline menu which seems different. I have therefore changed the color of only that icon in order to respect the cmdline.

Screenshots shown of completion with blink and these highlight groups.

[jakmaz]

this looks really nice, looking forward for it to be merged!

[ethanuppal]

Also hyped

[xStormyy]

Thank you for the PR!

I would personally change one thing though, and that is the background's and border's color of the documentation (which are the popups for the code snippets in the screenshots) to be the same color as in the existing cmp highlights, which is base00.

[boydkelly]

i had just let blink do its thing for some of the default settings where these linked to existing oxocarbon settings. I can see that there are defaults for the documentation window that point ot NormalFload and FloatBorder which Oxocarbon handles. Also the completion menu links to Pmenu highlight group. There don't seem to be any settings in the existing 'cmp' section that reference the menu background at all. But would they not be Pmenu and Float by default as well?

-- blink defaults here:
(custom-set-face! :BlinkCmpMenu [] {:link "Pmenu"})     <--- set in my proposal but also blink default value
(custom-set-face! :BlinkCmpDoc [] {:link "NormalFloat"})  <---- unset but blink defautl
(custom-set-face! :BlinkCmpDocBorder [] {:link "FloatBorder"})  <--unset but blink default

--  current oxocarbon values for above:
(custom-set-face! :Pmenu [] {:fg oxocarbon.base04 :bg oxocarbon.base01})
(custom-set-face! :NormalFloat [] {:fg oxocarbon.base05 :bg oxocarbon.blend})
(custom-set-face! :FloatBorder [] {:fg oxocarbon.blend :bg oxocarbon.blend})

But I don't see any refs at all by cmp to the menu background in the exisitng config. Are you suggesting to change the background of the BlinkCmpDoc and BlinkCmpDocBorder to base00?

[xStormyy]

I am suggesting BlinkCmpDoc and BlinkCmpDocBorder to be base00, yeah. I think cmp's styling is just an effect of cmp doing it's own thing with styles. Regardless, I feel like staying consistent with cmp is still something we should do.