This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
fix(ionic-angular): drop eslint config update #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
@nxext/ionic-angular:application
generator on Nx v19.8.0 the generator fails to update the ESLint config.The reason is that Nx generates an ESLint config in JS instead of JSON. The format of the file is very different from the JSON one so instead of trying to patch the
updateEslintConfig
function to make it work with the new format, I rather decided to remove the function completely to keep the code as simple as possible. Let me know if you think it's better to support the.js
format.