Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

fix(ionic-angular): drop eslint config update #42

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

edbzn
Copy link
Member

@edbzn edbzn commented Sep 23, 2024

When running the @nxext/ionic-angular:application generator on Nx v19.8.0 the generator fails to update the ESLint config.

NX   Cannot find apps/test/.eslintrc.json

Error: Cannot find apps/test/.eslintrc.json
    at readJson (/xxx/node_modules/@nxext/ionic-angular/node_modules/nx/src/generators/utils/json.js:14:15)
    at updateJson (/xxx/node_modules/@nxext/ionic-angular/node_modules/nx/src/generators/utils/json.js:46:34)
    at updateEslintConfig (/xxx/node_modules/@nxext/ionic-angular/src/generators/application/lib/update-eslint-config.js:6:29)
    at /xxx/node_modules/@nxext/ionic-angular/src/generators/application/generator.js:21:55
    at Generator.next (<anonymous>)
    at fulfilled (/xxx/node_modules/tslib/tslib.js:166:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

The reason is that Nx generates an ESLint config in JS instead of JSON. The format of the file is very different from the JSON one so instead of trying to patch the updateEslintConfig function to make it work with the new format, I rather decided to remove the function completely to keep the code as simple as possible. Let me know if you think it's better to support the .js format.

@edbzn edbzn requested a review from DominikPieper September 23, 2024 07:36
@DominikPieper
Copy link
Member

I'm not sure they're still relevant. The expected eslint config is from years ago, the format changed a lot in that time

@edbzn edbzn merged commit cdc9d7c into nxext:main Sep 23, 2024
1 check passed
@edbzn edbzn deleted the drop-eslint-config-update branch September 23, 2024 08:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants