prevent crash on win.showDevTools in normal build flavor #8213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushmanchhabra
changed the title
ayushmanchhabra
changed the title
|
@rogerwang is this implementation okay or do you want the error to be returned via the callback as shown below? win.showDevTools((status, error) => {
if (error) {
console.error(error)
}
}); |
ayushmanchhabra
changed the title
|
Currently the changed code returns the error via callback and exits the function. Is this implementation fine? |
ayushmanchhabra
force-pushed
the
dev-7844
branch
2 times, most recently
from
83af01f to
465a146
Compare
ayushmanchhabra
force-pushed
the
dev-7844
branch
from
465a146 to
d8db825
Compare
|
Can this be merged in before releasing nw92? |
|
@rogerwang requesting for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7844
Fixes: #8012