WIP: Fix validation #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlie-ht
force-pushed
the
fix-validation
branch
from
b672987 to
5042058
Compare
VK_LAYER_KHRONOS_validation is the more modern layer name. VK_EXT_DEBUG_REPORT_EXTENSION_NAME was mistakenly being requested as a layer, request the instance extension instead. Signed-off-by: Charlie Turner <[email protected]>
This happens in noPresent mode, since we aren't supposed to be retrieving queues from these families. Signed-off-by: Charlie Turner <[email protected]>
And use it to ignore the buffer profile information errors. These will become optional soon, and wiring them into the sample app is problematic, since the bitstream buffers are created before the video profile is known! Signed-off-by: Charlie Turner <[email protected]>
charlie-ht
force-pushed
the
fix-validation
branch
from
5042058 to
7d2e082
Compare
This one seems a bug in the parser or the spec VU. The parser updates the count independently on the parameter objects, the spec expects the count to be global. Hack it for now. Signed-off-by: Charlie Turner <[email protected]>
Fixes a validation error. This should take account of whether noPresent is given, that hasn't been wired in yet. m_useLinearOutput is not a sufficient check. TODO Signed-off-by: Charlie Turner <[email protected]>
The output path in particular was assuming linear tiling was OK, it's not advertised on RADV. These checks should be more extensive. Signed-off-by: Charlie Turner <[email protected]>
This is not complete, but silences some validation warnings. Before all features were being turned off! Signed-off-by: Charlie Turner <[email protected]>
charlie-ht
force-pushed
the
fix-validation
branch
from
7d2e082 to
1a93a58
Compare
Add a macro for aligning address and use it in a few more places
This seems to require more knowledge about the DPB management in the parser than I have at the moment. We don't get any help from it for the setup reference slot.
charlie-ht
force-pushed
the
fix-validation
branch
from
1a93a58 to
2a1f2ce
Compare
Contributor
Author
|
Superceded by #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still more to do, just opening this to track the progress.