Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make errors more visible with vim.notify #432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

teto
Copy link
Member

@teto teto commented Jun 28, 2024

the spinner is too discrete and there is a green tick once it finishes so at first I thought the install had succeeded but paying closer attention, the message up/down of it said install had failed

I haven't tested yet. Just putting it out there to see what people think

the spinner is too discrete and there is a green tick once it finishes so at first I thought the install had succeeded but paying closer attention, the message up/down of it said install had failed
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb mrcjkb enabled auto-merge (squash) June 30, 2024 01:19
Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we'd also want this for :Rocks update?

@vhyrro
Copy link
Collaborator

vhyrro commented Jul 5, 2024

Wait, why is there a green tick at the end, if there were errors during the process? I feel like that should be the meat of this problem. I personally feel like a notify and a message in fidget.nvim is slightly too much :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants