Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicit overriding of url #564

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

teto
Copy link
Member

@teto teto commented Dec 19, 2024

my PR at nvim-neorocks/nurr#33 fails because the generated URL is
local repo_url = 'https://github.com/https://git.sr.ht/~whynothugo/lsp_lines.nvim'.
It's apparently already possible to override the default url via GIT_SERVER_URL_OVERRIDE but making it an explicit input is easier to discover ?

@mrcjkb
Copy link
Member

mrcjkb commented Dec 20, 2024

Afaik the only use case where we would want to override the URL is in NURR, which is why it's not an explicit input. I'd prefer to avoid having too many inputs.

Ideally, we should port this workflow to other platforms (GitLab, sr.ht, ...).

@teto
Copy link
Member Author

teto commented Dec 24, 2024

Afaik the only use case where we would want to override the URL is in NURR, which is why it's not an explicit input. I'd prefer to avoid having too many inputs.

I can use GIT_SERVER_URL_OVERRIDE instead.

Ideally, we should port this workflow to other platforms (GitLab, sr.ht, ...).

I find it easier if it's centralized ? it should be more work to have a nurr per-platform.

@mrcjkb
Copy link
Member

mrcjkb commented Dec 24, 2024

I find it easier if it's centralized ? it should be more work to have a nurr per-platform.

That's not what I meant. I meant that we should port this workflow to other platforms, so that repos that are hosted on gitlab, etc. can auto-push to luarocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants