Skip to content

feat(Modal/Slideover): add after:enter event - #4187

Merged
benjamincanac merged 2 commits into
nuxt:v3from
genu:feat/add-after-enter-event
May 23, 2025
Merged

benjamincanac merged 2 commits into
nuxt:v3from
genu:feat/add-after-enter-event

Conversation

@genu

@genu genu commented May 19, 2025

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolves #4149

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds a @after-enter event to be able to handle cases where we must wait for the transition to complete

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new

pkg-pr-new Bot commented May 19, 2025 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@4187

commit: 9e843ee

@benjamincanac benjamincanac changed the title feat(modal): add 'after:enter' event to Modal component feat(Modal): add after:enter event May 22, 2025

@benjamincanac benjamincanac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@genu Shouldn't this be implemented in Slideover.vue and OverlayProvider.vue as well? 🤔

@genu

genu commented May 22, 2025 •

Copy link
Copy Markdown
Member Author

@genu Shouldn't this be implemented in Slideover.vue and OverlayProvider.vue as well? 🤔

You're right. I added the event to the Slideover as well.

For OverlayProvider, I don't believe its necessary as users should be able to use the same after-enter event inside the dynamic component

We only need to add it to OverlayProvider if we need to do anything internally, or expose the event to the useOverlay composable

@benjamincanac benjamincanac changed the title feat(Modal): add after:enter event feat(Modal/Slideover): add after:enter event May 23, 2025
@benjamincanac
benjamincanac merged commit d9e9fea into nuxt:v3 May 23, 2025
@benjamincanac

Copy link
Copy Markdown
Member

Thanks @genu! 😊

@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 #1289

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modal Component @after:enter event

2 participants