Skip to content

fix(Table): update styles for thead and th elements to show border fr… #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: v3
Choose a base branch
from

Conversation

larseberhardt
Copy link

@larseberhardt larseberhardt commented May 5, 2025

…om thead at the correct position in safari

Screenshot 2025-05-05 at 19 06 07

Resolves #4180

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is my first PR! Sorry if there is something wrong. I've noticed today that the border in the table header move to the end of the table in Safari. Tried to fix it with still using the after pseudo element but I had no luck. Now we're not using the after element at all. The calculation in th is that the content doesn't get shifted by the border. You shouldn't notice any change in Chrome but this fixes the bug in Safari

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Member

I see the issue on Safari, however your solution doesn't really fix the issue as it breaks the border on Chrome with sticky header. The sticky head was the reason I used ::after to set the border, it's a tricky one 😬

@larseberhardt
Copy link
Author

Uh I didn't checked with sticky header. I don't really get behind what Safari wants that it is displaying the pseudo element correct. I can see if I can find a other solution to fix it for Safari.

@benjamincanac benjamincanac marked this pull request as draft May 7, 2025 12:38
@benjamincanac benjamincanac added the v3 #1289 label May 7, 2025
@larseberhardt
Copy link
Author

I've figured out how it works with the pseudo after in safari and chrome. Instead of after:bottom-0 using after:end-full is doing it correctly.

@benjamincanac
Copy link
Member

It seems it does break the loading though 😬 Both bg now apply into thead::after and still need to see the gray border under the loading bar 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Border on table header not shown on safari, loading indicator not on the top
2 participants